Repository navigation
Matern32Kernel and Matern52Kernel keep Float32 - #610
Merged
theogf merged 3 commits intoOct 10, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #610 +/- ##
===========================================
+ Coverage 68.61% 93.52% +24.91%
===========================================
Files 52 52
Lines 1453 1468 +15
===========================================
+ Hits 997 1373 +376
+ Misses 456 95 -361 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
theogf
reviewed
Oct 4, 2026
theogf
reviewed
Oct 4, 2026
…n the input's float type
Member
|
Thanks for addressing the points, LGTM |
theogf
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
kappaofMatern32KernelandMatern52Kernelmultiplies bysqrt(3)andsqrt(5), which are Float64, so a Float32 kernel matrix (and any GP built on it) is promoted to Float64. This PR forms the constant at the distance's type (sqrt(5 * one(d))), the same fix #560 made forPeriodicKernel. Float64 results are unchanged, and each kernel gets a test that itskappaof a Float32 is a Float32.